Skip to content

repl: ensure correct syntax error for await parsing #39154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 6 commits into from
Closed

repl: ensure correct syntax error for await parsing #39154

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6956816
repl: ensure correct syntax error for await parsing
guybedford Jun 25, 2021
c162852
fixup: remove redundant check
guybedford Jun 25, 2021
0cb7f22
fixup: pr feedback
guybedford Jun 25, 2021
96781d6
fixup: recoverable handling
guybedford Jun 27, 2021
b75ad06
fixup: Update lib/internal/repl/await.js
guybedford Jun 27, 2021
2a3a06b
fixup: add startswith import
guybedford Jun 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: recoverable handling
  • Loading branch information
@guybedford
guybedford committed Jun 30, 2021
commit 96781d683e1fa7b652ae79ac543a09291811bb35
3 changes: 3 additions & 0 deletions lib/internal/repl/await.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const {

const parser = require('internal/deps/acorn/acorn/dist/acorn').Parser;
const walk = require('internal/deps/acorn/acorn-walk/dist/walk');
const { Recoverable } = require('internal/repl');

const noop = FunctionPrototype;
const visitorsWithoutAncestors = {
Expand Down Expand Up @@ -94,6 +95,8 @@ function processTopLevelAwait(src) {
try {
root = parser.parse(wrapped, { ecmaVersion: 'latest' });
} catch (e) {
if (e.message.startsWith('Unterminated '))
Comment thread
guybedford marked this conversation as resolved.
Outdated
throw new Recoverable(e);
// If the parse error is before the first "await", then use the execution
// error. Otherwise we must emit this parse error, making it look like a
// proper syntax error.
Expand Down