Skip to content

async_hooks: check for empty contexts before removing #39095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bengl wants to merge 3 commits into from
Closed

async_hooks: check for empty contexts before removing #39095

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a401e4
async_hooks: check for empty contexts before removing
bengl Jun 19, 2021
979bd0b
fixup! review feedback
bengl Jun 21, 2021
9acb32f
fixup! check for empty contexts in SetJSPromiseHooks too
bengl Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! check for empty contexts in SetJSPromiseHooks too
  • Loading branch information
@bengl
bengl committed Jun 21, 2021
commit 9acb32fbbdb3ff6613e810fda5effc065f8e3e43
5 changes: 5 additions & 0 deletions src/env-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ inline void AsyncHooks::SetJSPromiseHooks(v8::Local<v8::Function> init,
js_promise_hooks_[2].Reset(env()->isolate(), after);
js_promise_hooks_[3].Reset(env()->isolate(), resolve);
for (auto it = contexts_.begin(); it != contexts_.end(); it++) {
if (it->IsEmpty()) {
it = contexts_.erase(it);
it--;
continue;
}
PersistentToLocal::Weak(env()->isolate(), *it)
->SetPromiseHooks(init, before, after, resolve);
}
Expand Down