Skip to content

debugger: remove final lint exceptions in inspect_repl.js #39078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

debugger: remove final lint exceptions in inspect_repl.js #39078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
debugger: remove final lint exceptions in inspect_repl.js 
Adding a return when it's not really a getter is kind of misleading, but
so is using a getter for something that doesn't return anything, so
¯\_(ツ)_/¯.

PR-URL: #39078
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@Trott
Trott committed Jun 26, 2021
commit 3c099874aae60b42cf549ad3efd67f0ff153d571
7 changes: 2 additions & 5 deletions lib/internal/debugger/inspect_repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
// TODO(trott): enable ESLint
/* eslint-disable getter-return */

'use strict';

const {
Expand Down Expand Up @@ -899,7 +896,7 @@ function createRepl(inspector) {

copyOwnProperties(context, {
get help() {
print(HELP);
return print(HELP);
},

get run() {
Expand Down Expand Up @@ -1078,7 +1075,7 @@ function createRepl(inspector) {
repl.setPrompt('> ');

print('Press Ctrl+C to leave debug repl');
repl.displayPrompt();
return repl.displayPrompt();
},

get version() {
Expand Down