Skip to content

doc: Extend esm examples, document and lint import forms for process + Buffer #39043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 9 commits into from
Closed

doc: Extend esm examples, document and lint import forms for process + Buffer #39043

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1875962
doc: Extend esm examples /w imports for process + Buffer
guybedford Jun 15, 2021
60a75e9
Apply suggestions from code review
guybedford Jun 15, 2021
fef62a1
Update doc/api/async_context.md
guybedford Jun 15, 2021
e3eb511
update process examples to use destructured imports
guybedford Jun 15, 2021
70683b0
bmeck feedback, including eslintrc globals
guybedford Jun 15, 2021
694e172
fixup all Buffer, process usage per lint rule
guybedford Jun 15, 2021
e3943e9
fixup lint file
guybedford Jun 15, 2021
25feabf
revert removing dynamic import in crypto examples
guybedford Jun 15, 2021
37247c8
Update doc/api/async_hooks.md
guybedford Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@guybedford @aduh95
guybedford and aduh95 authored Jun 15, 2021
commit 60a75e924fae4f506aeb1e3dc906bd03e8457b40
6 changes: 4 additions & 2 deletions doc/api/async_hooks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ this.
```mjs
import { createServer } from 'net';

net.createServer().listen(function() { this.close(); });
createServer().listen(function() { this.close(); });
// OR
clearTimeout(setTimeout(() => {}, 10));
```
Expand Down Expand Up @@ -358,6 +358,7 @@ The following is a simple demonstration of `triggerAsyncId`:
```mjs
import { createHook, executionASyncId } from 'async_hooks';
import { stdout } from 'process';
Comment thread
guybedford marked this conversation as resolved.
import net from 'net';

createHook({
init(asyncId, type, triggerAsyncId) {
Expand All @@ -374,6 +375,7 @@ net.createServer((conn) => {}).listen(8080);
```cjs
const { createHook, executionAsyncId } = require('async_hooks');
const { fd } = require('process').stdout;
Comment thread
guybedford marked this conversation as resolved.
const net = require('net');

createHook({
init(asyncId, type, triggerAsyncId) {
Expand Down Expand Up @@ -613,7 +615,7 @@ import { open } from 'fs';
import { executionAsyncId, executionAsyncResource } from 'async_hooks';

console.log(executionAsyncId(), executionAsyncResource()); // 1 {}
open(fileURLToPath(import.meta.url), 'r', (err, fd) => {
open(new URL(import.meta.url), 'r', (err, fd) => {
console.log(executionAsyncId(), executionAsyncResource()); // 7 FSReqWrap
});
```
Expand Down