Skip to content

stream: compose #39029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 8 commits into from
Closed

stream: compose #39029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4918a15
stream: add stream.compose
ronag Jun 18, 2021
d065a2b
fixup: remove async fn support
ronag Jul 12, 2021
882b15b
fixup
ronag Jul 12, 2021
0cf9ee5
fixup
ronag Jul 12, 2021
9fa8a9f
fixup
ronag Jul 12, 2021
26bdf98
fixup: alpha order
ronag Jul 12, 2021
87302f0
Apply suggestions from code review
ronag Jul 13, 2021
dc80a26
fixup
ronag Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@ronag @targos
ronag and targos authored Jul 13, 2021
commit 87302f01b8d372ddf5cc1588a09353f56d2cbe4f
4 changes: 2 additions & 2 deletions lib/internal/streams/compose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ module.exports = function compose(...streams) {

for (let n = 0; n < streams.length; ++n) {
if (!isNodeStream(streams[n])) {
// TODO (ronag): Add checks for non streams.
// TODO(ronag): Add checks for non streams.
continue;
}
if (n < streams.length - 1 && !isReadable(streams[n])) {
Expand Down Expand Up @@ -113,7 +113,7 @@ module.exports = function compose(...streams) {
const writable = !!isWritable(head);
const readable = !!isReadable(tail);

// TODO (ronag): Avoid double buffering.
// TODO(ronag): Avoid double buffering.
// Implement Writable/Readable/Duplex traits.
// See, https://github.com/nodejs/node/pull/33515.
d = new ComposeDuplex({
Expand Down
2 changes: 1 addition & 1 deletion lib/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Stream.finished = eos;
Stream.destroy = destroyer;

Stream.compose = function(...streams) {
Comment thread
ronag marked this conversation as resolved.
Outdated
// TODO (ronag): Remove this once async function API
// TODO(ronag): Remove this once async function API
// has been discussed.
for (let n = 0; n < streams.length; ++n) {
if (!isNodeStream(streams[n])) {
Expand Down