Skip to content

errors: remove source map rekey logic #39025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 5 commits into from
Closed

errors: remove source map rekey logic #39025

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
773ea75
errors: don't rekey on primitive type
Jun 13, 2021
0b67b1e
Update lib/internal/source_map/source_map_cache.js
Jun 13, 2021
9a7fad6
stop rekeying cjs cache
Jun 13, 2021
4af02fd
delete more code
Jun 13, 2021
b56a914
test: update test to reflect refactor
Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/source_map/source_map_cache.js 
Co-authored-by: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@Trott
Benjamin E. Coe and Trott authored Jun 13, 2021
commit 0b67b1e8310c6b62166d9835bbeff3b446c3a8fb
2 changes: 1 addition & 1 deletion lib/internal/source_map/source_map_cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ function sourcesToAbsolute(baseURL, data) {
// Move source map from garbage collected module to alternate key.
function rekeySourceMap(cjsModuleInstance, newInstance) {
const sourceMap = cjsSourceMapCache.get(cjsModuleInstance);
// If an exception occurs before a module finishes loading it will removed
// If an exception occurs before a module finishes loading, it is removed
// from the module cache and our WeakMap. To allow a source map to still be
// applied to the stack trace when this happens, we rekey on the thrown error.
// This is only possible if the error is an object and not a primitive type.
Expand Down