Skip to content

bootstrap: split NodeMainInstance::Run() and move handle checking code to the snapshot builder #39007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

bootstrap: split NodeMainInstance::Run() and move handle checking code to the snapshot builder #39007

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee344b
bootstrap: split NodeMainInstance::Run()
joyeecheung Jun 11, 2021
d73a4d8
bootstrap: move event loop handle checking into snapshot builder
joyeecheung Jun 11, 2021
767278e
fixup! bootstrap: move event loop handle checking into snapshot builder
joyeecheung Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! bootstrap: move event loop handle checking into snapshot builder 
Co-authored-by: Voltrex <mohammadkeyvanzade94@gmail.com>
  • Loading branch information
@joyeecheung @VoltrexKeyva
joyeecheung and VoltrexKeyva authored Jun 15, 2021
commit 767278efaa281cda9ce0619e7fde76efb590b9bd
3 changes: 2 additions & 1 deletion src/node_snapshotable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ void SnapshotBuilder::Generate(SnapshotData* out,
// We cannot resurrect the handles from the snapshot, so make sure that
// no handles are left open in the environment after the blob is created
// (which should trigger a GC and close all handles that can be closed).
if (!env->req_wrap_queue()->IsEmpty() || !env->handle_wrap_queue()->IsEmpty()
if (!env->req_wrap_queue()->IsEmpty()
|| !env->handle_wrap_queue()->IsEmpty()
|| per_process::enabled_debug_list.enabled(DebugCategory::MKSNAPSHOT)) {
PrintLibuvHandleInformation(env->event_loop(), stderr);
}
Expand Down