Skip to content

test: remove obsolete TLS test #39001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Jun 13, 2021
+0 −13
Merged

test: remove obsolete TLS test #39001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove obsolete TLS test 
The test involving melissadata.net was to make sure Node.js still
tolerated ValiCert 1024-bit certs. It has been several years since
melissadata.net used ValiCert as a root certificate and for that matter,
we removed ValiCert in a4dbf45 so it
would have broken then if it was still using it. The test is no longer
valid or needed and hasn't been for several years.

PR-URL: #39001
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@Trott
Trott committed Jun 13, 2021
commit 5b3587dbc64cc298701b62f8767d37976d57a451
13 changes: 0 additions & 13 deletions test/internet/test-tls-connnect-melissadata.js
View file
Open in desktop

This file was deleted.