Skip to content

[v16.x backport] deps: update V8 to 9.1 #38991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 20 commits into from
Closed

[v16.x backport] deps: update V8 to 9.1 #38991

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5ae4174
deps: update V8 to 9.1.269.36
targos Jun 10, 2021
177d398
build: reset embedder string to "-node.0"
targos Jun 10, 2021
4c8186c
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
e3a5f1d
deps: V8: patch register-arm64.h
refack May 22, 2019
86e3e85
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
72e24b4
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
081c31f
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
1548507
deps: V8: backport aaacffa1e003
targos Apr 19, 2021
5d666c7
deps: silence irrelevant V8 warnings
targos Jan 30, 2021
0735b58
deps: V8: cherry-pick d59db06bf542
targos Apr 17, 2021
c4b044f
deps: V8: cherry-pick c0fceaa0669b
targos May 17, 2021
f3c6065
deps: V8: cherry-pick 272445f10927
targos May 17, 2021
36a0606
deps: V8: cherry-pick 5f4413194480
targos May 17, 2021
ad32c41
deps: V8: cherry-pick 4c074516397b
targos May 17, 2021
97524cf
deps: V8: cherry-pick fa4cb172cde2
targos May 17, 2021
2af1e04
tools: update V8 gypfiles for 9.1
targos Mar 3, 2021
4cbd9e1
test: fix V8 serdes test for V8 9.1
targos Mar 27, 2021
c509532
test: adapt test-linux-perf to V8 changes
targos May 18, 2021
fd88ec2
test: adapt abort tests for new Windows code
targos May 19, 2021
f33c128
deps: make V8 9.1 abi-compatible with 9.0
targos Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: make v8.h compatible with VS2015 
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693

PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@joaocgreis @targos
joaocgreis authored and targos committed Jun 11, 2021
commit 72e24b4ed3538fd4b8cb8c2c75ba3f5e0b708841
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.3',
'v8_embedder_string': '-node.4',

##### V8 defaults for Node.js #####

Expand Down
6 changes: 6 additions & 0 deletions deps/v8/include/v8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,7 +1427,9 @@ class ScriptOriginOptions {
*/
class ScriptOrigin {
public:
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
V8_DEPRECATE_SOON("Use constructor with primitive C++ types")
#endif
V8_INLINE explicit ScriptOrigin(
Local<Value> resource_name, Local<Integer> resource_line_offset,
Local<Integer> resource_column_offset,
Expand All @@ -1438,7 +1440,9 @@ class ScriptOrigin {
Local<Boolean> is_wasm = Local<Boolean>(),
Local<Boolean> is_module = Local<Boolean>(),
Local<PrimitiveArray> host_defined_options = Local<PrimitiveArray>());
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
V8_DEPRECATE_SOON("Use constructor that takes an isolate")
#endif
V8_INLINE explicit ScriptOrigin(
Local<Value> resource_name, int resource_line_offset = 0,
int resource_column_offset = 0,
Expand Down Expand Up @@ -1938,9 +1942,11 @@ class V8_EXPORT ScriptCompiler {
public:
enum Encoding { ONE_BYTE, TWO_BYTE, UTF8, WINDOWS_1252 };
Comment thread
targos marked this conversation as resolved.

#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
V8_DEPRECATED(
"This class takes ownership of source_stream, so use the constructor "
"taking a unique_ptr to make these semantics clearer")
#endif
StreamedSource(ExternalSourceStream* source_stream, Encoding encoding);
StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream,
Encoding encoding);
Expand Down