Skip to content

build: apply workaround for msbuild 16.10.0 only #38930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 2 commits into from
Closed

build: apply workaround for msbuild 16.10.0 only #38930

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51a4795
build: apply workaround for msbuild 16.10.0 only
richardlau Jun 4, 2021
e25056b
fixup! build: apply workaround for msbuild 16.10.0 only
richardlau Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,11 @@ if "%target%"=="Build" (
if defined cctest set target="Build"
)
if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"
@rem TODO(targos): Remove next line after MSBuild 16.10.1 is released.
if "%target%"=="node" set target="Build"
@rem Workaround bug in MSBuild 16.10.0. (https://github.com/dotnet/msbuild/pull/6465)
for /F %%V in ('msbuild -version -nologo') do set msbuild_ver=%%V
if "%msbuild_ver:~0,8%"=="16.10.0." (
Comment thread
richardlau marked this conversation as resolved.
Outdated
if "%target%"=="node" set target="Build"
)
if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"
@rem Setup env variables to use multiprocessor build
set UseMultiToolTask=True
Expand Down