Skip to content

[v14.x backport] deps,debugger: move node-inspect into core #38858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 12 commits into from
Closed

[v14.x backport] deps,debugger: move node-inspect into core #38858

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eff3c97
debugger: move node-inspect to internal library
Trott Apr 8, 2021
d286b75
tools: remove node-inspect from license
Trott Apr 8, 2021
7ee45c0
debugger: remove unused code
Trott Apr 8, 2021
802e4c1
debugger: fix inspect restart on Windows
Trott Apr 20, 2021
8a6448d
debugger: accommodate line chunking in Windows
Trott Apr 21, 2021
8ec940d
debugger: allow longer time to connect
Trott Apr 21, 2021
e5ee810
test: fix test-inspector-cli-address
Trott Apr 22, 2021
767dc25
test,debugger: migrate node-inspect tests to core
Trott Apr 9, 2021
9d5ab8f
debugger: replace internal use of deprecated API
Trott Apr 20, 2021
5357c18
test: fix comment typo
Trott Apr 22, 2021
d2263ef
debugger: fix race condition/deadlock on initialization
Trott Apr 23, 2021
22cbfa8
test: extend timeout on debugger tests for slower machines
Trott Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix test-inspector-cli-address 
The test was assuming that the entire string being sought would arrive
in a single data chunk, but it can be split across multiple chunks.

PR-URL: #38161
Backport-PR-URL: #38858
Refs: https://github.com/nodejs/node/discussions/36481
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@Trott
Trott committed Jul 15, 2021
commit e5ee810827641f8f3b7ed425a45c3e41aac5b482
4 changes: 3 additions & 1 deletion deps/node-inspect/test/cli/address.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ function launchTarget(...args) {
};
childProc.on('exit', onExit);
childProc.stderr.setEncoding('utf8');
childProc.stderr.on('data', (data) => {
let data = '';
childProc.stderr.on('data', (chunk) => {
data += chunk;
const ret = kDebuggerMsgReg.exec(data);
childProc.removeListener('exit', onExit);
if (ret) {
Expand Down