Skip to content

src: remove deadcode in node_file.cc #38693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juanarbol wants to merge 1 commit into from
Closed

src: remove deadcode in node_file.cc #38693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: remove commented code in node_file.cc 
The implementation of the `fs.lchmod` method has been moved to JS-land
  • Loading branch information
@juanarbol
juanarbol committed May 16, 2021
commit b0722e70d91898720f3b26998e8b4d2144ab7ea5
2 changes: 0 additions & 2 deletions src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2482,7 +2482,6 @@ void Initialize(Local<Object> target,

env->SetMethod(target, "chmod", Chmod);
env->SetMethod(target, "fchmod", FChmod);
// env->SetMethod(target, "lchmod", LChmod);

env->SetMethod(target, "chown", Chown);
env->SetMethod(target, "fchown", FChown);
Expand Down Expand Up @@ -2599,7 +2598,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {

registry->Register(Chmod);
registry->Register(FChmod);
// registry->Register(LChmod);

registry->Register(Chown);
registry->Register(FChown);
Expand Down