Skip to content

fs: fix rmsync error swallowing #38684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linkgoron wants to merge 4 commits into from
Closed

fs: fix rmsync error swallowing #38684

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f359272
fs: fix rmsync error swallowing
Linkgoron May 13, 2021
0f91128
fixup! fs: fix rmsync error swallowing
Linkgoron May 19, 2021
089fd73
fixup! fixup! fs: fix rmsync error swallowing
Linkgoron May 19, 2021
7e888a2
fixup! fixup! fixup! fs: fix rmsync error swallowing
Linkgoron May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fs: fix rmsync error swallowing
  • Loading branch information
@Linkgoron
Linkgoron committed May 19, 2021
commit 0f911280910cb0d331eca133e6b6ee527bcfdcf2
4 changes: 2 additions & 2 deletions test/parallel/test-fs-rm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ function removeAsync(dir) {
}

{
// check endless recursion.
// Check endless recursion.
// https://github.com/nodejs/node/issues/34580
const dirname = nextDirPath();
fs.mkdirSync(dirname, { recursive: true });
Expand All @@ -336,7 +336,7 @@ function removeAsync(dir) {
fs.mkdirSync(middle);
fs.mkdirSync(path.join(middle, 'leaf')); // Make `middle` non-empty
const mode = common.isWindows ? 0 : 0o555;
const code = common.isWindows ? 'EPERM': 'EACCES';
const code = common.isWindows ? 'EPERM' : 'EACCES';
try {
fs.chmodSync(middle, mode);
assert.throws(() => {
Expand Down