Skip to content

bootstrap: include vm and contextify binding into the snapshot #38677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

bootstrap: include vm and contextify binding into the snapshot #38677

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e4c2b
bootstrap: include vm and contextify binding into the snapshot
joyeecheung May 13, 2021
0fa0bff
fixup! bootstrap: include vm and contextify binding into the snapshot
joyeecheung May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! bootstrap: include vm and contextify binding into the snapshot
  • Loading branch information
@joyeecheung
joyeecheung committed May 14, 2021
commit 0fa0bffca481d70febebc45a790c003585bb19f2
2 changes: 2 additions & 0 deletions lib/internal/bootstrap/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,8 @@ function initializeESMLoader() {
setInitializeImportMetaObjectCallback(esm.initializeImportMetaObject);
setImportModuleDynamicallyCallback(esm.importModuleDynamicallyCallback);

// Patch the vm module when --experimental-vm-modules is on.
// Please update the comments in vm.js when this block changes.
if (getOptionValue('--experimental-vm-modules')) {
const {
Module, SourceTextModule, SyntheticModule,
Expand Down
4 changes: 4 additions & 0 deletions lib/vm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,3 +426,7 @@ module.exports = {
compileFunction,
measureMemory,
};

// The vm module is patched to include vm.Module, vm.SourceTextModule
// and vm.SyntheticModule in the pre-execution phase when
// --experimental-vm-modules is on.