Skip to content

test: stream.finished detects a destroyed IncomingMessage #38661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linkgoron wants to merge 2 commits into from
Closed

test: stream.finished detects a destroyed IncomingMessage #38661

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9bc54d
test: stream.finished detects a destroyed IncomingMessage
Linkgoron May 12, 2021
7da0b47
fixup! test: stream.finished detects a destroyed IncomingMessage
Linkgoron May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: stream.finished detects a destroyed IncomingMessage 
Add a test to verify that stream.finished works correctly
on IncomingMessage

refs: #38657
  • Loading branch information
@Linkgoron
Linkgoron committed May 12, 2021
commit c9bc54d47a0c882b8c3961b1cbe6602f970bad1c
16 changes: 16 additions & 0 deletions test/parallel/test-stream-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,22 @@ testClosed((opts) => new Writable({ write() {}, ...opts }));
});
}

{
const server = http.createServer((req, res) => {
req.on('close', () => {
finished(req, common.mustCall(() => {
server.close();
}));
});
req.destroy();
}).listen(0, function() {
Comment thread
Linkgoron marked this conversation as resolved.
Outdated
http.request({
method: 'GET',
port: this.address().port
}).end().on('error', common.mustCall());
});
}


{
const w = new Writable({
Expand Down