Skip to content

src: write named pipe info in diagnostic report #38637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 10 commits into from
Closed

src: write named pipe info in diagnostic report #38637

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
534db1a
src: write named pipe info in diagnostic report
legendecas May 11, 2021
74b1e3e
fixup! src: write named pipe info in diagnostic report
legendecas May 12, 2021
5dd9185
fixup! src: write named pipe info in diagnostic report
legendecas May 12, 2021
477e50f
fixup! src: write named pipe info in diagnostic report
legendecas May 16, 2021
0efa117
fixup! test: windows fanned test failed
legendecas May 17, 2021
69d3ea5
fixup! test: windows fanned test failed
legendecas May 17, 2021
6451d80
fixup! test: windows fanned test failed
legendecas May 18, 2021
0112fba
fixup! test: windows fanned test failed
legendecas May 19, 2021
14e0b9a
fixup! merge with common.PIPE
legendecas May 19, 2021
d5d6ee7
fixup! test: windows fanned test failed
legendecas May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src: write named pipe info in diagnostic report
  • Loading branch information
@legendecas
legendecas committed May 16, 2021
commit 477e50f39103030208899c0e690b7f00bd231ab3
12 changes: 8 additions & 4 deletions src/node_report_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@ static void ReportPipeEndpoints(uv_handle_t* h, JSONWriter* writer) {
rc = uv_pipe_getsockname(&handle->pipe, buffer.data, &buffer_size);
if (rc == UV_ENOBUFS) {
buffer = MallocedBuffer<char>(buffer_size);
Comment thread
addaleax marked this conversation as resolved.
rc = uv_pipe_getsockname(&handle->pipe, buffer.data, &buffer_size);
if (buffer.data != nullptr) {
rc = uv_pipe_getsockname(&handle->pipe, buffer.data, &buffer_size);
}
}
if (rc == 0 && buffer_size != 0) {
if (rc == 0 && buffer_size != 0 && buffer.data != nullptr) {
writer->json_keyvalue("localEndpoint", buffer.data);
} else {
writer->json_keyvalue("localEndpoint", null);
Expand All @@ -105,9 +107,11 @@ static void ReportPipeEndpoints(uv_handle_t* h, JSONWriter* writer) {
rc = uv_pipe_getpeername(&handle->pipe, buffer.data, &buffer_size);
if (rc == UV_ENOBUFS) {
buffer = MallocedBuffer<char>(buffer_size);
rc = uv_pipe_getpeername(&handle->pipe, buffer.data, &buffer_size);
if (buffer.data != nullptr) {
rc = uv_pipe_getpeername(&handle->pipe, buffer.data, &buffer_size);
}
}
if (rc == 0 && buffer_size != 0) {
if (rc == 0 && buffer_size != 0 && buffer.data != nullptr) {
writer->json_keyvalue("remoteEndpoint", buffer.data);
} else {
writer->json_keyvalue("remoteEndpoint", null);
Expand Down