Skip to content

doc: add node protocol to ESM and CommonJS api examples #38620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromecovington wants to merge 4 commits into from
Closed

doc: add node protocol to ESM and CommonJS api examples #38620

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4fec89
doc: use node protocol in ESM examples
jeromecovington May 9, 2021
ebb4ff0
doc: use node protocol in CommonJS examples
jeromecovington May 9, 2021
8e6349f
doc: ensure line <= 80 for markdown linter
jeromecovington May 10, 2021
7737f62
doc: remove errant usage of node:cjs
jeromecovington May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: remove errant usage of node:cjs
  • Loading branch information
@jeromecovington
jeromecovington committed May 18, 2021
commit 7737f62ad57948e0af461061e30cfea24cca9fd7
8 changes: 4 additions & 4 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,11 @@ module default import or its corresponding sugar syntax:

<!-- eslint-disable no-duplicate-imports -->
```js
import { default as cjs } from 'node:cjs';
import { default as cjs } from 'cjs';

// The following import statement is "syntax sugar" (equivalent but sweeter)
// for `{ default as cjsSugar }` in the above import statement:
import cjsSugar from 'node:cjs';
import cjsSugar from 'cjs';

console.log(cjs);
console.log(cjs === cjsSugar);
Expand All @@ -368,11 +368,11 @@ a namespace with a `default` export key pointing to the CommonJS
`module.exports` value.

This Module Namespace Exotic Object can be directly observed either when using
`import * as m from 'node:cjs'` or a dynamic import:
`import * as m from 'cjs'` or a dynamic import:

<!-- eslint-skip -->
```js
import * as m from 'node:cjs';
import * as m from 'cjs';
console.log(m);
console.log(m === await import('cjs'));
// Prints:
Expand Down