async_hooks: switch between native and context hooks correctly

🤦 Might help if I remember to disable the _other_ promise hook implementation when switching between them... Fixes #38814 Fixes #38815 Refs #36394 PR-URL: #38912 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Bryan English <bryan@bryanenglish.com>
nodejs · Qard · Apr 21, 2021 · Apr 22, 2021 · Apr 27, 2021 · Apr 29, 2021
commit be12749a602aebc13378e18f6e5214b9e6a54492
diff --git a/lib/internal/async_hooks.js b/lib/internal/async_hooks.js
@@ -357,7 +357,9 @@ function updatePromiseHookMode() {
   wantPromiseHook = true;
   if (destroyHooksExist()) {
     enablePromiseHook();
+    setPromiseHooks(undefined, undefined, undefined, undefined);
   } else {
+    disablePromiseHook();
     setPromiseHooks(
       initHooksExist() ? promiseInitHook : undefined,
       promiseBeforeHook,

diff --git a/test/parallel/test-async-hooks-correctly-switch-promise-hook.js b/test/parallel/test-async-hooks-correctly-switch-promise-hook.js
@@ -0,0 +1,77 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const async_hooks = require('async_hooks');
+
+// Regression test for:
+// - https://github.com/nodejs/node/issues/38814
+// - https://github.com/nodejs/node/issues/38815
+
+const layers = new Map();
+
+// Only init to start context-based promise hook
+async_hooks.createHook({
+  init(asyncId, type) {
+    layers.set(asyncId, {
+      type,
+      init: true,
+      before: false,
+      after: false,
+      promiseResolve: false
+    });
+  },
+  before(asyncId) {
+    if (layers.has(asyncId)) {
+      layers.get(asyncId).before = true;
+    }
+  },
+  after(asyncId) {
+    if (layers.has(asyncId)) {
+      layers.get(asyncId).after = true;
+    }
+  },
+  promiseResolve(asyncId) {
+    if (layers.has(asyncId)) {
+      layers.get(asyncId).promiseResolve = true;
+    }
+  }
+}).enable();
+
+// With destroy, this should switch to native
+// and disable context - based promise hook
+async_hooks.createHook({
+  init() { },
+  destroy() { }
+}).enable();
+
+async function main() {
+  return Promise.resolve();
+}
+
+main();
+
+process.on('exit', () => {
+  assert.deepStrictEqual(Array.from(layers.values()), [
+    {
+      type: 'PROMISE',
+      init: true,
+      before: true,
+      after: true,
+      promiseResolve: true
+    },
+    {
+      type: 'PROMISE',
+      init: true,
+      before: false,
+      after: false,
+      promiseResolve: true
+    },
+    {
+      type: 'PROMISE',
+      init: true,
+      before: true,
+      after: true,
+      promiseResolve: true
+    },
+  ]);
+});