Skip to content

build: add missing torque output sources #38576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardlau merged 1 commit into from
May 7, 2021
Merged

build: add missing torque output sources #38576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: add missing torque output sources 
The `torque_generated_definitions` target is missing some torque
generated files in its sources list when compared to the equivalent
target in V8's BUILD.gn.

PR-URL: #38576
Fixes: #38571
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@richardlau
richardlau committed May 7, 2021
commit 184e0f799c18e2c9ed546b4248201b3d70ed1f65
3 changes: 3 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,9 @@
'<(SHARED_INTERMEDIATE_DIR)/torque-generated/class-verifiers.h',
'<(SHARED_INTERMEDIATE_DIR)/torque-generated/factory.cc',
'<(SHARED_INTERMEDIATE_DIR)/torque-generated/objects-printer.cc',
'<@(torque_outputs_inl_inc)',
'<@(torque_outputs_cc)',
'<@(torque_outputs_inc)',
],
'include_dirs': [
'<(SHARED_INTERMEDIATE_DIR)',
Expand Down