Skip to content

test: call functions internally #38560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 1 commit into from
Closed

test: call functions internally #38560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: call functions internally 
All (or at least most) of the tests uses lambdas (or arrow functions if you will) to call these functions internally inside of directly calling them, this should also use this technique for consistency.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva authored May 5, 2021
commit b3fd47735500c53de8b9eb325595d203aded4ba1
4 changes: 2 additions & 2 deletions test/js-native-api/test_bigint/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ const {
assert.strictEqual(num, TestWords(num));
});

assert.throws(CreateTooBigBigInt, {
assert.throws(() => CreateTooBigBigInt(), {
name: 'Error',
message: 'Invalid argument',
});

// Test that we correctly forward exceptions from the engine.
assert.throws(MakeBigIntWordsThrow, {
assert.throws(() => MakeBigIntWordsThrow(), {
name: 'RangeError',
message: 'Maximum BigInt size exceeded'
});