Skip to content

stream: add a non-destroying iterator to Readable #38526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Linkgoron wants to merge 5 commits into from
Closed

stream: add a non-destroying iterator to Readable #38526

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e21ad8d
stream: add a non-destroying iterator to Readable
Linkgoron Apr 17, 2021
87f5316
fixup! stream: add a non-destroying iterator to Readable
Linkgoron May 4, 2021
468f9ea
fixup! fixup! stream: add a non-destroying iterator to Readable
Linkgoron May 4, 2021
4bb108b
fixup! fixup! fixup! stream: add a non-destroying iterator to Readable
Linkgoron May 12, 2021
f939af2
fixup! fixup! fixup! fixup! stream: add a non-destroying iterator to …
Linkgoron May 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! stream: add a non-destroying iterator to Readable
  • Loading branch information
@Linkgoron
Linkgoron committed May 4, 2021
commit 87f53168582bf4d3f7e4279d8aaede47737fce68
2 changes: 1 addition & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,7 +1547,7 @@ async function printIterator(readable) {
console.log(chunk); // Will print 2 and then 3
}

console.log(readable.destroyed); // true, stream was totally consumed
console.log(readable.destroyed); // True, stream was totally consumed
}

async function printSymbolAsyncIterator(readable) {
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/streams/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ Readable.prototype[SymbolAsyncIterator] = function() {
return streamToAsyncIterator(this);
};

Readable.prototype.iterator = function (options = {
Readable.prototype.iterator = function(options = {
destroyOnReturn: true,
destroyOnError: true,
}) {
Comment thread
Linkgoron marked this conversation as resolved.
Outdated
Expand Down