Skip to content

fs: use assert in fsCall argument checking #38519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pd4d10 wants to merge 2 commits into from
Closed

fs: use assert in fsCall argument checking #38519

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b702da4
fs: use `assert` in `fsCall` argument checking
pd4d10 May 3, 2021
d2a6b49
Update lib/internal/fs/promises.js
pd4d10 May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update lib/internal/fs/promises.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@pd4d10 @aduh95
pd4d10 and aduh95 authored May 6, 2021
commit d2a6b490d7c863eb4ac07948df33851d86848e3e
2 changes: 1 addition & 1 deletion lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ async function handleFdClose(fileOpPromise, closeFunc) {
}

async function fsCall(fn, handle, ...args) {
assert(handle instanceof FileHandle,
assert(handle[kRefs] !== undefined,
'handle must be an instance of FileHandle');

if (handle.fd === -1) {
Expand Down