Skip to content

Update to cjs-module-lexer@1.2.1 #38450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 4 commits into from
Closed

Update to cjs-module-lexer@1.2.1 #38450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ba5570
update to cjs-module-lexer@1.2.0
guybedford Apr 28, 2021
8d46da0
add docs change
guybedford Apr 28, 2021
ff96280
fixup tests
guybedford Apr 28, 2021
0224c90
cjs-module-lexer@1.2.1
guybedford Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup tests
  • Loading branch information
@guybedford
guybedford committed Apr 28, 2021
commit ff962801b543ca5ebb86339b4c1e3b6bd831e33a
3 changes: 2 additions & 1 deletion test/fixtures/es-modules/cjs-exports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ import { strictEqual, deepEqual } from 'assert';
import m, { π } from './exports-cases.js';
import * as ns from './exports-cases.js';

deepEqual(Object.keys(ns), ['?invalid', 'default', 'invalid identifier', 'isObject', 'z', 'π']);
deepEqual(Object.keys(ns), ['?invalid', 'default', 'invalid identifier', 'isObject', 'package', 'z', 'π']);
strictEqual(π, 'yes');
strictEqual(typeof m.isObject, 'undefined');
strictEqual(m.π, 'yes');
strictEqual(m.z, 'yes');
strictEqual(m.package, 10);
strictEqual(m['invalid identifier'], 'yes');
strictEqual(m['?invalid'], 'yes');

Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/es-modules/exports-cases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ if (global.maybe)
exports['invalid identifier'] = 'yes';
module.exports['?invalid'] = 'yes';
module.exports['π'] = 'yes';
exports.package = 10; // reserved word -> not used
exports.package = 10; // reserved word
Object.defineProperty(exports, 'z', { value: 'yes' });