Skip to content

typings: add typing for string decoder #38229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 4 commits into from
Dec 30, 2021
Merged

typings: add typing for string decoder #38229

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd2230b
typings: add typing for internal/string_decoder
Ayase-252 Apr 13, 2021
b9ccd90
fixup: typings: add typing for internal/string_decoder
Ayase-252 Apr 14, 2021
4aee5ee
fixup: add function description
Ayase-252 Apr 20, 2021
1d2dc41
fixup: mark optional parameters
Ayase-252 Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: typings: add typing for internal/string_decoder 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@Ayase-252 @targos
Ayase-252 and targos committed Apr 14, 2021
commit b9ccd90946a947eca0a6fceb320d1b21969b137b
3 changes: 2 additions & 1 deletion lib/string_decoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ const kNativeDecoder = Symbol('kNativeDecoder');
/**
*
* @param {string} enc
* @returns {"utf8" | "utf16le" | "hex" | "ascii" | "base64" | "latin1" | "base64url"}
* @returns {"utf8" | "utf16le" | "hex" | "ascii"
* | "base64" | "latin1" | "base64url"}
Comment thread
aduh95 marked this conversation as resolved.
*/
function normalizeEncoding(enc) {
const nenc = internalUtil.normalizeEncoding(enc);
Expand Down