Skip to content

stream: fix multiple Writable.destroy() calls. #38221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

stream: fix multiple Writable.destroy() calls. #38221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ae4e4a
stream: fix multiple Writable.destroy() calls.
ronag Apr 12, 2021
9bc7703
fixup: linting
ronag Apr 13, 2021
8fc0ef2
fixup
ronag Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: fix multiple Writable.destroy() calls. 
Calling Writable.destroy() multiple times in the same tick
could cause an assertion error.

Fixes: #38189
  • Loading branch information
@ronag
ronag committed Apr 12, 2021
commit 6ae4e4a86814f6dac68e0f603ba26fc41cc9939a
4 changes: 2 additions & 2 deletions lib/internal/streams/writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,10 +855,10 @@ Writable.prototype.destroy = function(err, cb) {

// Invoke pending callbacks.
if (
!state.destroyed && (
state.bufferedIndex < state.buffered.length ||
state[kOnFinished].length
) {
assert(!state.destroyed);
)) {
process.nextTick(errorBuffer, state);
}

Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-stream-writable-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,3 +460,14 @@ const assert = require('assert');
assert.strictEqual(write.destroyed, true);
}));
}

{
// Destroy twice
const write = new Writable({
write(chunk, enc, cb) { cb(); }
});

write.end(common.mustCall());
write.destroy();
write.destroy();
}