Skip to content

deps: V8: cherry-pick 501482cbc704 #38121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 2 commits into from
Apr 9, 2021
Merged

deps: V8: cherry-pick 501482cbc704 #38121

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca13f7a
deps: V8: cherry-pick 501482cbc704
cjihrig Apr 2, 2021
e96773b
test: add regression test for serdes readDouble()
cjihrig Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add regression test for serdes readDouble() 
Refs: #37978
PR-URL: #38121
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Apr 9, 2021
commit e96773b94bbfdfd0b9d5d449ece90e4e297f9c94
7 changes: 7 additions & 0 deletions test/parallel/test-v8-serdes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,10 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
/^TypeError: buffer must be a TypedArray or a DataView$/,
);
}

{
// Regression test for https://github.com/nodejs/node/issues/37978
assert.throws(() => {
new v8.Deserializer(new v8.Serializer().releaseBuffer()).readDouble();
}, /ReadDouble\(\) failed/);
}