Skip to content

suggestion for getSystemErrorMap() implementation #38101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EladKeyshawn wants to merge 14 commits into from
Closed

suggestion for getSystemErrorMap() implementation #38101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e0f0fc8
suggestion for getSystemErrorMap() impl
eladkishon Apr 5, 2021
54c6e38
lint
eladkishon Apr 5, 2021
36082c2
avoid unneeded call indirection
eladkishon Apr 6, 2021
7ea64bb
syntax sugar and minor changes
eladkishon Apr 7, 2021
306bdf7
add basic uv-errmap test
eladkishon Apr 9, 2021
792a9b5
make linter happy
eladkishon Apr 9, 2021
87fb10e
add API doc
eladkishon Apr 9, 2021
6d8e95e
rm line
eladkishon Apr 9, 2021
a5d1b2c
add back example of getSystemErrorName
eladkishon Apr 9, 2021
718019a
replaceme
eladkishon Apr 9, 2021
a443668
doc lint
eladkishon Apr 9, 2021
034779c
Apply suggestions from code review
eladkishon Apr 10, 2021
0e79eb9
rm line
eladkishon Apr 10, 2021
02b338e
Fix typo in util.md doc
eladkishon Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@eladkishon
eladkishon committed Apr 5, 2021
commit 54c6e38fd608a0d7d21d6fa54d81389c46191854
4 changes: 2 additions & 2 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,8 @@ function uvErrmapGet(name) {
}

function uvGetFullErrMap() {
uvBinding = lazyUv();
return uvBinding.getErrorMap();
uvBinding = lazyUv();
return uvBinding.getErrorMap();
}

const captureLargerStackTrace = hideStackFrames(
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,8 @@ function getSystemErrorName(err) {
}

function getSystemErrorMap() {
return uvGetFullErrMap();
}
return uvGetFullErrMap();
}
Comment thread
EladKeyshawn marked this conversation as resolved.

const kCustomPromisifiedSymbol = SymbolFor('nodejs.util.promisify.custom');
const kCustomPromisifyArgsSymbol = Symbol('customPromisifyArgs');
Expand Down
2 changes: 1 addition & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ function getSystemErrorName(err) {
}

Comment thread
EladKeyshawn marked this conversation as resolved.
function getSystemErrorMap() {
return internalErrorMap();
return internalErrorMap();
}
Comment thread
EladKeyshawn marked this conversation as resolved.
Outdated
// Keep the `exports =` so that various functions can still be monkeypatched
module.exports = {
Expand Down