Skip to content

test: fix flaky test-net-timeout #38060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: fix flaky test-net-timeout #38060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-net-timeout 
The check for an 800ms window makesw assumptions about a setTimeout()
not running late etc. Remove it.

Refs: #34289
  • Loading branch information
@Trott
Trott committed Apr 3, 2021
commit a66fdc18eb2f16e1c20e7bf69e45d19edf817d5c
4 changes: 0 additions & 4 deletions test/pummel/test-net-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const echo_server = net.createServer((socket) => {
});

socket.on('data', (d) => {
console.log(d);
socket.write(d);
});

Expand Down Expand Up @@ -105,7 +104,4 @@ process.on('exit', () => {
console.log(`diff = ${diff}`);

assert.ok(timeout < diff);

// Allow for 800 milliseconds more
assert.ok(diff < timeout + 800);
});