Skip to content

lib: add tsconfig internal contributions #38042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 8 commits into from
Closed

lib: add tsconfig internal contributions #38042

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f8a423
lib: add tsconfig for code completions
bmeck Apr 2, 2021
a84a0f4
order keys nit
bmeck Apr 2, 2021
12b6fa7
nit sort paths
bmeck Apr 2, 2021
87cfcbf
add primordials typings
bmeck Apr 2, 2021
85ea829
woops, undo the generator cruft for the typings
bmeck Apr 2, 2021
4abba01
nits and improvements
bmeck Apr 7, 2021
b636c82
Update typings/internalBinding.d.ts
bmeck Apr 7, 2021
927aa17
nits / make some mutations picked up
bmeck Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nits and improvements
  • Loading branch information
@bmeck
bmeck committed Apr 7, 2021
commit 4abba0118a6893a9b1d132b0896c8aa4f606ace8
3 changes: 3 additions & 0 deletions lib/internal/bootstrap/loaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ const legacyWrapperList = new SafeSet([
}

// Set up internalBinding() in the closure.
/**
* @type {InternalBinding}
*/
let internalBinding;
{
const bindingObj = ObjectCreate(null);
Expand Down
6 changes: 5 additions & 1 deletion lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,11 @@ function makeNodeErrorWithCode(Base, key) {
};
}

// This function removes unnecessary frames from Node.js core errors.
/**
* This function removes unnecessary frames from Node.js core errors.
* @template {(...args: any[]) => any} T
* @type {(fn: T) => T}
*/
function hideStackFrames(fn) {
// We rename the functions that will be hidden to cut off the stacktrace
// at the outermost one
Expand Down
6 changes: 5 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
{
"include": ["lib","doc"],
"exclude": ["src","tools","out"],
"files": ["./typings/primordials.d.ts"],
"files": [
"./typings/internalBinding.d.ts",
"./typings/primordials.d.ts"
],
"compilerOptions": {
"allowJs": true,
"checkJs": false,
"noEmit": true,
"lib": ["ESNext"],
"target": "ESNext",
"module": "CommonJS",
"baseUrl": ".",
Expand Down
Loading