Skip to content

doc: sending http request to localhost to avoid https redirect #38036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hassaanp wants to merge 3 commits into from
Closed

doc: sending http request to localhost to avoid https redirect #38036

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2da6327
doc: sending http request to localhost to avoid https redirect
hassaanp Apr 2, 2021
3b346d4
Update doc/api/http.md
hassaanp Apr 2, 2021
3b2f38c
Update doc/api/http.md
hassaanp Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: sending http request to localhost to avoid https redirect 
In the JSON fetching example, http.get request is being sent to an http url that redirects to https. This causes the http.get request to fail. To avoid redirect errors, a local http server is set up that returns a json response.

Fixes: #37907
  • Loading branch information
@hassaanp
hassaanp committed Apr 2, 2021
commit 2da6327f1237ec44ccdcd71636f0848dffe3ca12
12 changes: 11 additions & 1 deletion doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2720,7 +2720,7 @@ The `callback` is invoked with a single argument that is an instance of
JSON fetching example:

```js
http.get('http://nodejs.org/dist/index.json', (res) => {
http.get('http://localhost:8000/', (res) => {
const { statusCode } = res;
const contentType = res.headers['content-type'];

Expand Down Expand Up @@ -2755,6 +2755,16 @@ http.get('http://nodejs.org/dist/index.json', (res) => {
}).on('error', (e) => {
console.error(`Got error: ${e.message}`);
});

// Create a local server to receive data from
const server = http.createServer((req, res) => {
res.writeHead(200, { 'content-type': 'application/json' });
Comment thread
hassaanp marked this conversation as resolved.
Outdated
res.end(`{
'data': 'hello world'
}`);
Comment thread
hassaanp marked this conversation as resolved.
Outdated
});

server.listen(8000);
```

## `http.globalAgent`
Expand Down