Skip to content

fs: fix chown abort #38004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 5 commits into from
Closed

fs: fix chown abort #38004

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5402b26
fs: fix chown abort
RaisinTen Mar 31, 2021
0c5fea2
fixup! fs: fix chown abort
RaisinTen Mar 31, 2021
d9c96b6
update validation in fs promises
RaisinTen Mar 31, 2021
97e3d0c
fixup! update validation in fs promises
RaisinTen Mar 31, 2021
9749f64
fixup! update validation in fs promises
RaisinTen Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! update validation in fs promises
  • Loading branch information
@RaisinTen
RaisinTen committed Mar 31, 2021
commit 97e3d0c25d8c0138acd52959485c457f571481f1
8 changes: 4 additions & 4 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,24 +191,24 @@ async function getHandle(dest) {

assert.rejects(
async () => {
await chown(dest, 1, -1);
await chown(dest, 1, -2);
},
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "gid" is out of range. ' +
'It must be >= 0 && < 4294967296. Received -1'
'It must be >= -1 && < 4294967296. Received -2'
});

assert.rejects(
async () => {
await handle.chown(1, -1);
await handle.chown(1, -2);
},
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "gid" is out of range. ' +
'It must be >= 0 && < 4294967296. Received -1'
'It must be >= -1 && < 4294967296. Received -2'
});

await handle.close();
Expand Down