Skip to content

Fix node crashing due to endless loop #37757 #37990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nils91 wants to merge 14 commits into from
Closed

Fix node crashing due to endless loop #37757 #37990

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0a3aa58
test: ensure node doesnt crash with some selfsigned certificates
nils91 Mar 30, 2021
00aca61
test: add empty line for readability
nils91 Mar 30, 2021
d4dd0b4
test: let server choose a port to use
nils91 Mar 31, 2021
832811d
test: move https selfsigned to parallel
nils91 Mar 31, 2021
5dca179
test: wrap callbacks in common.must[Not]Call
nils91 Mar 31, 2021
e3bd5f5
crypto: exit potentially infinite loop in GetLastIssuedCert if stuck
nils91 Mar 30, 2021
0734ad0
crypto: more compact solution to detect endless loop
nils91 Mar 31, 2021
374335d
Revert "crypto: more compact solution to detect endless loop"
nils91 Apr 1, 2021
fe0fcbb
crypto: put the condition at the very end of the loop
nils91 Apr 1, 2021
b59150b
test: skip for OpenSSL<=1.1.1h
nils91 Apr 3, 2021
b5b0c91
test: remove unnecessary body from .mustNotCall
nils91 Apr 3, 2021
bb5bfde
test: fix typo, '<' instead of '<='
nils91 Apr 4, 2021
080ac2e
test: improve test readability
nils91 Apr 4, 2021
a44ed4b
test: skip test when openssl_is_fips
nils91 Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "crypto: more compact solution to detect endless loop" 
This reverts commit bd978e1.
  • Loading branch information
@nils91
nils91 committed Apr 23, 2021
commit 374335d019c15f603dbe6227434d94942438324c
13 changes: 8 additions & 5 deletions src/crypto/crypto_common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,14 +480,17 @@ MaybeLocal<Object> GetLastIssuedCert(
return MaybeLocal<Object>();
issuer_chain = ca_info;

// Take the value of cert->get(), compare it with the value of ca
// and provide a way to exit this loop
// in case it gets stuck.
if (cert->get() == ca)
break;
// Take the value of cert->get() before and after the call to cert->reset()
// in order to compare them and provide a way to exit this loop
// in case it gets stuck
X509* value_before_reset = cert->get();

// Delete previous cert and continue aggregating issuers.
cert->reset(ca);

X509* value_after_reset = cert->get();
if (value_before_reset == value_after_reset)
Comment thread
nils91 marked this conversation as resolved.
Outdated
break;
}
return MaybeLocal<Object>(issuer_chain);
}
Expand Down