Skip to content

tools: simplify eslint comma-dangle configuration #37850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Mar 23, 2021
Merged

tools: simplify eslint comma-dangle configuration #37850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: simplify eslint comma-dangle configuration 
Remove comma-dangle settings in benchmark/.eslintrc.yaml as they are the
same as what is set in .eslintrc.js.

PR-URL: #37850
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott
Trott committed Mar 23, 2021
commit 448158e0f87caec6fde76ee3c4aaf1da1c7aafc1
6 changes: 0 additions & 6 deletions benchmark/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,4 @@ env:

rules:
no-var: error
comma-dangle:
- error
- arrays: 'always-multiline'
objects: 'only-multiline'
imports: 'only-multiline'
exports: 'only-multiline'
prefer-arrow-callback: error