Skip to content

lib: make process.binding('util') return only type checkers #37819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
+74 −0
Closed

lib: make process.binding('util') return only type checkers #37819

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d77751e
lib: make process.binding('util') return only type checkers
addaleax Mar 19, 2021
1930676
fixup: lib: make process.binding('util') return only type checkers
addaleax Mar 19, 2021
7ae04f6
fixup! lib: make process.binding('util') return only type checkers
addaleax Mar 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! lib: make process.binding('util') return only type checkers 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@addaleax @aduh95
addaleax and aduh95 authored Mar 20, 2021
commit 7ae04f66a2427de8687eb51e8bcf3b769777810d
5 changes: 3 additions & 2 deletions lib/internal/legacy/processbinding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@ const {
ArrayPrototypeIncludes,
ObjectFromEntries,
ObjectEntries,
SafeArrayIterator,
} = primordials;
const { types } = require('util');

module.exports = {
util() {
return ObjectFromEntries(ArrayPrototypeFilter(
return ObjectFromEntries(new SafeArrayIterator(ArrayPrototypeFilter(
ObjectEntries(types),
({ 0: key }) => {
return ArrayPrototypeIncludes([
Expand All @@ -30,6 +31,6 @@ module.exports = {
'isUint8Array',
'isAnyArrayBuffer',
], key);
}));
})));
}
};