Skip to content

test: fix flaky test-http2-pack-end-stream-flag #37814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 1 commit into from
Closed

test: fix flaky test-http2-pack-end-stream-flag #37814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-http2-pack-end-stream-flag 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37639
  • Loading branch information
@jasnell
jasnell committed Mar 19, 2021
commit 6e9ccf6aebc8b90c9780665e91ad32b08987f736
15 changes: 9 additions & 6 deletions test/parallel/test-http2-pack-end-stream-flag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,15 @@ server.on('stream', (stream, headers) => {
function testRequest(path, targetFrameCount, callback) {
const obs = new PerformanceObserver(
common.mustCallAtLeast((list, observer) => {
const entry = list.getEntries()[0];
if (entry.name !== 'Http2Session') return;
if (entry.detail.type !== 'client') return;
assert.strictEqual(entry.detail.framesReceived, targetFrameCount);
observer.disconnect();
callback();
const entries = list.getEntries();
for (let n = 0; n < entries.length; n++) {
const entry = entries[n];
if (entry.name !== 'Http2Session') continue;
if (entry.detail.type !== 'client') continue;
assert.strictEqual(entry.detail.framesReceived, targetFrameCount);
observer.disconnect();
callback();
}
}));
obs.observe({ type: 'http2' });
const client =
Expand Down