Skip to content

v12.22.0 proposal #37797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardlau merged 17 commits into from
Mar 30, 2021
Merged

v12.22.0 proposal #37797

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0a35d49
Revert "embedding: make Stop() stop Workers"
addaleax Apr 2, 2020
6cef0e3
src,test: add regression test for nested Worker termination
addaleax Apr 2, 2020
a0b6104
http: runtime deprecate legacy HTTP parser
BethGriggs Mar 4, 2021
dfa04d9
deps: V8: cherry-pick beebee4f80ff
psmarshall Aug 5, 2020
0f6d445
test: add cpu-profiler-crash test
santigimeno Feb 9, 2021
eec7542
worker: add eventLoopUtilization()
trevnorris Oct 14, 2020
d7a4ccd
test: correct test-worker-eventlooputil
Flarna Oct 31, 2020
8ddea3f
v8: implement v8.takeCoverage()
joyeecheung Jun 9, 2020
86f34ee
v8: implement v8.stopCoverage()
joyeecheung Jun 9, 2020
f569209
node-api: allow retrieval of add-on file name
Feb 12, 2021
bf8733f
doc: mark modules implementation as stable
guybedford Oct 23, 2020
1872625
deps: update to cjs-module-lexer@1.1.0
guybedford Mar 11, 2021
93dd799
node-api: define version 8
gabrielschulhof Mar 7, 2021
2da24ac
lib: add URI handling functions to primordials
aduh95 Feb 16, 2021
7b0ed4b
module: improve support of data: URLs
aduh95 Feb 16, 2021
364bf03
test: fix races in test-performance-eventlooputil
Flarna Nov 7, 2020
6a5797b
2021-03-30, Version 12.22.0 'Erbium' (LTS)
richardlau Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src,test: add regression test for nested Worker termination 
This adds a regression test for terminating a Worker inside which
another Worker is running.

PR-URL: #32623
Refs: #32531
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
@addaleax @richardlau
addaleax authored and richardlau committed Feb 23, 2021
commit 6cef0e3678345a12044519ed90faf9d943a89892
2 changes: 2 additions & 0 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,8 @@ void Environment::Exit(int exit_code) {
}

void Environment::stop_sub_worker_contexts() {
DCHECK_EQ(Isolate::GetCurrent(), isolate());

while (!sub_worker_contexts_.empty()) {
Worker* w = *sub_worker_contexts_.begin();
remove_sub_worker_context(w);
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-worker-terminate-nested.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';
const common = require('../common');
const { Worker } = require('worker_threads');

// Check that a Worker that's running another Worker can be terminated.

const worker = new Worker(`
const { Worker, parentPort } = require('worker_threads');
const worker = new Worker('setInterval(() => {}, 10);', { eval: true });
worker.on('online', () => {
parentPort.postMessage({});
});
`, { eval: true });

worker.on('message', common.mustCall(() => worker.terminate()));