http: refactor to avoid unsafe array iteration

PR-URL: #37654 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
nodejs · danielleadams · Mar 7, 2021 · Feb 24, 2021 · Mar 9, 2021 · Mar 11, 2021
commit 77c5c2f3d1cf16e82c83fc7d11d1b14c145dd2df
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -27,6 +27,7 @@ const {
   ArrayPrototypePop,
   ArrayPrototypePush,
   ArrayPrototypeShift,
+  ArrayPrototypeSome,
   ArrayPrototypeSplice,
   FunctionPrototypeCall,
   NumberIsNaN,
@@ -390,10 +391,10 @@ function installListeners(agent, s, options) {
     // Destroy if in free list.
     // TODO(ronag): Always destroy, even if not in free list.
     const sockets = agent.freeSockets;
-    for (const name of ObjectKeys(sockets)) {
-      if (ArrayPrototypeIncludes(sockets[name], s)) {
-        return s.destroy();
-      }
+    if (ArrayPrototypeSome(ObjectKeys(sockets), (name) =>
+      ArrayPrototypeIncludes(sockets[name], s)
+    )) {
+      return s.destroy();
     }
   }
   s.on('timeout', onTimeout);
@@ -449,7 +450,9 @@ Agent.prototype.removeSocket = function removeSocket(s, options) {
     // There might be older requests in a different origin, but
     // if the origin which releases the socket has pending requests
     // that will be prioritized.
-    for (const prop of ObjectKeys(this.requests)) {
+    const keys = ObjectKeys(this.requests);
+    for (let i = 0; i < keys.length; i++) {
+      const prop = keys[i];
       // Check whether this specific origin is already at maxSockets
       if (this.sockets[prop] && this.sockets[prop].length) break;
       debug('removeSocket, have a request with different origin,' +