Skip to content

test: fix flaky wpt/test-timers #37691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Mar 14, 2021
Merged

test: fix flaky wpt/test-timers #37691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: address flaky wpt/test-timers 
Moving test harness from Parallel to Simple resolves most of the
failures. negative-settimeout.any.js still needs to be marked flaky.

Refs: #37672

PR-URL: #37691
Fixes: #37672
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@Trott
Trott committed Mar 14, 2021
commit 66f0eb7dc3f34c517038ff5e2da471aaafc306c8
6 changes: 5 additions & 1 deletion test/wpt/status/html/webappapis/timers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
{}
{
"negative-settimeout.any.js": {
"fail": "unreliable in Node.js; Refs: https://github.com/nodejs/node/issues/37672"
}
}
2 changes: 1 addition & 1 deletion test/wpt/testcfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
import testpy

def GetConfiguration(context, root):
return testpy.ParallelTestConfiguration(context, root, 'wpt')
return testpy.SimpleTestConfiguration(context, root, 'wpt')