Skip to content

test: ignore WPT worker errors after tests finished #37626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 1 commit into from
Closed

test: ignore WPT worker errors after tests finished #37626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: ignore WPT worker errors after tests finished 
This can happen normally, for example in timers tests.
  • Loading branch information
@targos
targos committed Mar 6, 2021
commit d22b0df7b881d7d5c303c1ef368f185d5fc0f261
5 changes: 5 additions & 0 deletions test/common/wpt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,11 @@ class WPTRunner {
});

worker.on('error', (err) => {
if (!this.inProgress.has(testFileName)) {
// The test is already finished. Ignore errors that occur after it.
// This can happen normally, for example in timers tests.
return;
}
this.fail(
testFileName,
{
Expand Down
15 changes: 1 addition & 14 deletions test/wpt/status/html/webappapis/timers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1 @@
{
"negative-settimeout.any.js": {
"fail": "assert_unreached: Reached unreachable code"
},
"type-long-setinterval.any.js": {
"fail": "assert_unreached: Reached unreachable code"
},
"type-long-settimeout.any.js": {
"fail": "assert_unreached: Reached unreachable code"
},
"negative-setinterval.any.js": {
"fail": "assert_unreached: Reached unreachable code"
}
}
{}