Skip to content

build: use Ninja in action workflows #37499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 5 commits into from
Closed

build: use Ninja in action workflows #37499

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8213b3c
build: use Ninja in action workflows
targos Feb 24, 2021
c117869
fixup! build: use Ninja in action workflows
targos Feb 24, 2021
b7d5022
fixup! fixup! build: use Ninja in action workflows
targos Feb 24, 2021
f2321c0
fixup! fixup! fixup! build: use Ninja in action workflows
targos Feb 24, 2021
1005055
fixup! fixup! fixup! fixup! build: use Ninja in action workflows
targos Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: use Ninja in action workflows 
Until we have a fix for the makefiles generated by GYP.

Refs: #37429
  • Loading branch information
@targos
targos committed Feb 24, 2021
commit 8213b3ce1287e2d133b9da2a0ca47efd8e526c18
2 changes: 1 addition & 1 deletion .github/workflows/build-tarball.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Build
run: |
cd $TAR_DIR
make build-ci -j2 V=1
make build-ci -j2 V=1 CONFIG_FLAGS="--ninja"
- name: Test
run: |
cd $TAR_DIR
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-asan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
CC: clang
CXX: clang++
LINK: clang++
CONFIG_FLAGS: --enable-asan
CONFIG_FLAGS: --enable-asan --ninja
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --ninja"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions"
2 changes: 1 addition & 1 deletion .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --ninja"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions"