Skip to content

contextify: cache some context in locals #37473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XadillaX wants to merge 2 commits into from
Closed

contextify: cache some context in locals #37473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df3b95
contextify: cache some context in locals
XadillaX Feb 22, 2021
0d624d8
f
XadillaX Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
f
  • Loading branch information
@XadillaX
XadillaX committed Feb 24, 2021
commit 0d624d88d167b864c71571920fc0e4444e7b898b
6 changes: 3 additions & 3 deletions src/node_contextify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ MaybeLocal<Context> ContextifyContext::CreateV8Context(
return MaybeLocal<Context>();
}

auto context = env->context();
Local<Context> context = env->context();
ctx->SetSecurityToken(context->GetSecurityToken());

// We need to tie the lifetime of the sandbox object with the lifetime of
Expand Down Expand Up @@ -782,7 +782,7 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
}
contextify_script->script_.Reset(isolate, v8_script.ToLocalChecked());

auto env_context = env->context();
Local<Context> env_context = env->context();
if (compile_options == ScriptCompiler::kConsumeCodeCache) {
args.This()->Set(
env_context,
Expand Down Expand Up @@ -892,7 +892,7 @@ void ContextifyScript::RunInContext(const FunctionCallbackInfo<Value>& args) {
ContextifyContext::ContextFromContextifiedSandbox(env, sandbox);
CHECK_NOT_NULL(contextify_context);

auto context = contextify_context->context();
Local<Context> context = contextify_context->context();
if (context.IsEmpty())
return;

Expand Down