Skip to content

src: fix alloc-dealloc-mismatch in node_snapshotable.h #37443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 1 commit into from
Closed

src: fix alloc-dealloc-mismatch in node_snapshotable.h #37443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: fix alloc-dealloc-mismatch in node_snapshotable.h 
Fixes: #37442
  • Loading branch information
@RaisinTen
RaisinTen committed Feb 20, 2021
commit 3789d143fcd98813357e9b0e617236ed7ddd2468
6 changes: 3 additions & 3 deletions src/node_snapshotable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,20 @@ struct InternalFieldInfo {

static InternalFieldInfo* New(EmbedderObjectType type, size_t length) {
InternalFieldInfo* result =
reinterpret_cast<InternalFieldInfo*>(::operator new(length));
reinterpret_cast<InternalFieldInfo*>(::operator new[](length));
result->type = type;
result->length = length;
return result;
}

InternalFieldInfo* Copy() const {
InternalFieldInfo* result =
reinterpret_cast<InternalFieldInfo*>(::operator new(length));
reinterpret_cast<InternalFieldInfo*>(::operator new[](length));
memcpy(result, this, length);
return result;
}

void Delete() { ::operator delete(this); }
void Delete() { ::operator delete[](this); }
};

// An interface for snapshotable native objects to inherit from.
Expand Down