Skip to content

fs: fix mode validation #37432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 4 commits into from
Closed

fs: fix mode validation #37432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90ed832
fs: validate mode in ReadStream and WriteStream
RaisinTen Feb 18, 2021
95479ff
add tests
RaisinTen Feb 18, 2021
49132cc
mask mode with 0xFFFFFFFF
RaisinTen Feb 18, 2021
e2760b5
Revert "fs: validate mode in ReadStream and WriteStream"
RaisinTen Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests
  • Loading branch information
@RaisinTen
RaisinTen committed Feb 18, 2021
commit 95479ffbe151d38a4f4368e5639358e8fd6a257f
3 changes: 3 additions & 0 deletions test/parallel/test-fs-read-stream-throw-type-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,6 @@ const NOT_SAFE_INTEGER = 2 ** 53;
].forEach((opts) =>
createReadStreamErr(example, opts, rangeError)
);

// Case 8: Should throw RangeError if mode is out of range
createReadStreamErr(example, { mode: 2176057344 }, rangeError);
24 changes: 24 additions & 0 deletions test/parallel/test-fs-write-stream-throw-range-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict';
require('../common');

// This test ensures that createWriteStream throws a RangeError when
// an out of range mode is passed in the options, as reported here:
// https://github.com/nodejs/node/issues/37430

const assert = require('assert');
const fs = require('fs');
const path = require('path');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

const example = path.join(tmpdir.path, 'dummy');

assert.throws(
() => {
fs.createWriteStream(example, { mode: 2176057344 });
},
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError'
});