Skip to content

fix: incorrect timers-promisified test case #37425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ttzztztz wants to merge 10 commits into from
Closed

fix: incorrect timers-promisified test case #37425

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
983b371
fix: incorrect timers-promisified case
ttzztztz Feb 18, 2021
3cd01f5
lint: fix
ttzztztz Feb 18, 2021
3ee0be9
test: must_call for Promise.all
ttzztztz Feb 18, 2021
2bc172d
fix: test failure
ttzztztz Feb 18, 2021
e5acfda
fix: test failure
ttzztztz Feb 18, 2021
a9737b5
Update test/parallel/test-timers-promisified.js
ttzztztz Feb 18, 2021
9359f9c
Update test/parallel/test-timers-promisified.js
ttzztztz Feb 18, 2021
7509a44
Update test/parallel/test-timers-promisified.js
ttzztztz Feb 18, 2021
51921f7
feat: timer_unit
ttzztztz Feb 19, 2021
2ddaa1d
fix: efficient machines
ttzztztz Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: test failure
  • Loading branch information
@ttzztztz
ttzztztz committed Feb 18, 2021
commit 2bc172dd697033589ab7a7fa34aae3faab4a167c
4 changes: 2 additions & 2 deletions test/parallel/test-timers-promisified.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,9 @@ process.on('multipleResolves', common.mustNotCall());
let post = false;

Promise.all([
setPromiseTimeout(100).then(() => pre = true),
setPromiseTimeout(1).then(() => pre = true),
new Promise((res) => {
const iterable = setInterval(() => {}, 200);
const iterable = timerPromises.setInterval(() => {}, 200);
const iterator = iterable[Symbol.asyncIterator]();

iterator.next().then(common.mustCall(() => {
Comment thread
ttzztztz marked this conversation as resolved.
Outdated
Expand Down