Skip to content

Policy scope fix #37298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 5 commits into from
Closed

Policy scope fix #37298

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d74f91e
policy: fix cascading getting the resource instead of scope
bmeck Feb 9, 2021
aeffffe
missing files
bmeck Feb 9, 2021
925b2c8
Update lib/internal/policy/manifest.js
bmeck Feb 15, 2021
bfb4aa5
Update lib/internal/policy/manifest.js
bmeck Feb 15, 2021
ac2a32b
fixup on nits
bmeck Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup on nits
  • Loading branch information
@bmeck
bmeck committed Feb 15, 2021
commit ac2a32b48f5bff549741944e74dd1203aefa3b9f
6 changes: 3 additions & 3 deletions lib/internal/policy/manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ class Manifest {
*/
constructor(obj, manifestURL) {
const scopes = this.#scopeDependencies;
scopes.set(null, TERMINATE);
scopes.set(undefined, TERMINATE);
scopes.set(null, kTerminate);
scopes.set(undefined, kTerminate);
const integrities = this.#resourceIntegrities;
const dependencies = this.#resourceDependencies;
let reaction = REACTION_THROW;
Expand Down Expand Up @@ -423,7 +423,7 @@ class Manifest {
protocol = currentURL.protocol;
}
// Only a few schemes are hierarchical
if (SPECIAL_SCHEMES.has(currentURL.protocol)) {
if (kSpecialSchemes.has(currentURL.protocol)) {
// Make first '..' act like '.'
if (!StringPrototypeEndsWith(currentURL.pathname, '/')) {
currentURL.pathname += '/';
Expand Down