Skip to content

v10.23.3 proposal #37241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardlau merged 5 commits into from
Feb 9, 2021
Merged

v10.23.3 proposal #37241

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
953a850
crypto: fix crash when calling digest after piping
tniessen Jun 16, 2019
1c6fbd6
test: add test that verifies crypto stream pipeline
evanlucas Jan 20, 2021
7b7fb43
Revert "deps: upgrade npm to 6.14.11"
richardlau Feb 8, 2021
fe2c980
deps: upgrade npm to 6.14.11
ruyadorno Feb 1, 2021
ef1c506
2021-02-09, Version 10.23.3 'Dubnium' (LTS)
richardlau Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add test that verifies crypto stream pipeline 
This test fails prior to 990feaf being cherry-picked
due to stream.pipeline with a crypto.Hash not working properly.

That bug also seems to have affected md5.

PR-URL: #37009
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
@evanlucas @richardlau
evanlucas authored and richardlau committed Feb 8, 2021
commit 1c6fbd6ffe7eb10053be3cfb84dc4ae11b4d94c3
21 changes: 21 additions & 0 deletions test/parallel/test-crypto-hash-stream-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';

const common = require('../common');

if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const crypto = require('crypto');
const stream = require('stream');

const hash = crypto.createHash('md5');
const s = new stream.PassThrough();
const expect = 'e8dc4081b13434b45189a720b77b6818';

s.write('abcdefgh');
stream.pipeline(s, hash, common.mustCall(function(err) {
assert.ifError(err);
assert.strictEqual(hash.digest('hex'), expect);
}));
s.end();