Skip to content

fs: add fsPromises.watch() #37179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

fs: add fsPromises.watch() #37179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f74c6
fs: add fsPromises.watch()
jasnell Feb 1, 2021
6e27a09
fixup! fs: add fsPromises.watch()
jasnell Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fs: add fsPromises.watch()
  • Loading branch information
@jasnell
jasnell committed Feb 15, 2021
commit 6e27a093b8097d28963b7ab854f12dca5cb2c71b
31 changes: 0 additions & 31 deletions test/parallel/test-fs-promises-watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,34 +113,3 @@ assert.rejects(
assert.strictEqual(err.name, 'AbortError');
}
})().then(common.mustCall());

fs.rmdirSync(tmpdir.path, { recursive: true });
tmpdir.refresh();

for (const testCase of kCases) {
if (testCase.shouldSkip) continue;
fs.mkdirSync(testCase.dirPath);
// Long content so it's actually flushed.
const content1 = Date.now() + testCase.fileName.toLowerCase().repeat(1e4);
fs.writeFileSync(testCase.filePath, content1);

const ac = new AbortController();

async function test() {
const { signal } = ac;
const watcher = watch(testCase[testCase.field], { signal });
assert.rejects(watcher.next(), {
name: 'AbortError'
});
}

// Long content so it's actually flushed. toUpperCase so there's real change.
const content2 = Date.now() + testCase.fileName.toUpperCase().repeat(1e4);
setImmediate(() => {
fs.writeFileSync(testCase.filePath, '');
fs.writeFileSync(testCase.filePath, content2);
ac.abort();
});

test().then(common.mustCall());
}