Skip to content

test: remove flaky designation for test-http2-large-file #37156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Feb 3, 2021
+0 −2
Merged

test: remove flaky designation for test-http2-large-file #37156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove flaky designation for test-http2-large-file 
This seems to have stopped happening, possibly because it only ever
happened on win2008 and that went eol last year.

Closes: #22327

PR-URL: #37156
Fixes: #22327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott
Trott committed Feb 3, 2021
commit 4f44cadc54a6f858a31543bf61d2be96e974ee48
2 changes: 0 additions & 2 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ prefix sequential
test-cpu-prof-dir-worker: PASS, FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/22327
test-http2-large-file: PASS, FLAKY
# https://github.com/nodejs/node/issues/26401
test-worker-prof: PASS, FLAKY

Expand Down