Skip to content

fs: change default value of position in read and readSync #37101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RaisinTen wants to merge 4 commits into from
+60 −12
Closed

fs: change default value of position in read and readSync #37101

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
446bdb6
fs: change default value of position in read and readSync
RaisinTen Jan 27, 2021
44dfe5d
fixup! fs: change default value of position in read and readSync
RaisinTen Apr 1, 2021
42a31d1
Revert "fixup! fs: change default value of position in read and readS…
RaisinTen Apr 2, 2021
9342709
use default parameter
RaisinTen Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fixup! fs: change default value of position in read and readS… 
…ync"

This reverts commit 44dfe5d.
  • Loading branch information
@RaisinTen
RaisinTen committed Apr 2, 2021
commit 42a31d1cab451b6f0da43bf93f94f7b95b9331ee
2 changes: 1 addition & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ function tryReadSync(fd, isUserFd, buffer, pos, len) {
let threw = true;
let bytesRead;
try {
bytesRead = fs.readSync(fd, buffer, pos, len, -1);
bytesRead = fs.readSync(fd, buffer, pos, len);
threw = false;
} finally {
if (threw && !isUserFd) fs.closeSync(fd);
Expand Down