Skip to content

crypto: add keyObject.export() JWK format option #37081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 10 commits into from
Closed

crypto: add keyObject.export() JWK format option #37081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9f6e3d1
crypto: add keyObject.export() 'jwk' format option
panva Jan 26, 2021
5ba12fb
add custom doc type
panva Jan 26, 2021
1cfd243
add doc changes entry
panva Jan 26, 2021
25a6c8c
address doc comments
panva Jan 26, 2021
955696f
add makefile for fixtures
panva Jan 26, 2021
a76db7a
get a curve not supported on openssl111fips
panva Jan 26, 2021
5f03cdf
Update doc/api/crypto.md
panva Jan 26, 2021
5ca795c
apply review feedback
panva Jan 31, 2021
44d49e0
address nits
panva Feb 1, 2021
a6d1e96
fail on private export with a passphrase
panva Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address nits
  • Loading branch information
@panva
panva committed Feb 2, 2021
commit 44d49e07bde6e63dbac7a67ba96500d37c407e61
2 changes: 1 addition & 1 deletion doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,7 +1351,7 @@ added: v11.6.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/37081
description: Added support for `'jwk' format`.
description: Added support for `'jwk'` format.
-->

* `options`: {Object}
Expand Down
9 changes: 5 additions & 4 deletions test/parallel/test-crypto-key-objects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,10 +659,10 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
// SecretKeyObject export buffer format (default)
const buffer = Buffer.from('Hello World');
const keyObject = createSecretKey(buffer);
assert(buffer.equals(keyObject.export()));
assert(buffer.equals(keyObject.export({})));
assert(buffer.equals(keyObject.export({ format: 'buffer' })));
assert(buffer.equals(keyObject.export({ format: undefined })));
assert.deepStrictEqual(keyObject.export(), buffer);
assert.deepStrictEqual(keyObject.export({}), buffer);
assert.deepStrictEqual(keyObject.export({ format: 'buffer' }), buffer);
assert.deepStrictEqual(keyObject.export({ format: undefined }), buffer);
}

{
Expand All @@ -681,6 +681,7 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
// Find an unsupported curve regardless of whether a FIPS compliant crypto
// provider is currently in use.
const namedCurve = getCurves().find((curve) => !supported.includes(curve));
Comment thread
panva marked this conversation as resolved.
assert(namedCurve);
const keyPair = generateKeyPairSync('ec', { namedCurve });
const { publicKey, privateKey } = keyPair;
assert.throws(
Expand Down